Conversation
palas
requested review from
a team,
CarlosLopezDeLara,
Jimbo4350,
carbolymer,
dcoutts,
disassembler,
erikd,
kevinhammond and
newhoggy
as code owners
palas
force-pushed
the
qualify-js-from-proto
branch
from
3a63c60 to
a124c8e
Compare
palas
force-pushed
the
qualify-js-from-proto
branch
from
a124c8e to
635558f
Compare
Jimbo4350
approved these changes
Jul 24, 2025
carbolymer
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Previous solution in PR #913 doesn't work, because each generated
.jsfile uses the same namespace, and they override each other. So this PR modifies the script that generates them to produce a single.jsfile that has their exports qualified by their module name, so that we only need to import one file, and so that the namespaces don't collide.This PR also updates all the code that used it, and generalises the wasm library so that it also stores the clients qualified, and thus it can do multiple different types of queries easily.
How to trust this PR
I think, again testing is the most important bit. Also ensure the code style is good, and the comments are up to date, enough, and clear.
Checklist